Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
E
emailapi
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 5
    • Merge Requests 5
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Extensions
  • emailapi
  • Merge Requests
  • !17

Open
Opened Sep 18, 2020 by mattwire@mattwireContributor
  • Report abuse
Report abuse

Refactor email activity creation

  • Overview 3
  • Commits 2
  • Changes 2

This refactors how email activities are created to fix some bugs and allow it to work better with extensions like https://lab.civicrm.org/extensions/msgtplblocker

  1. Make sure we always have a source_contact_id set to create an activity (otherwise it will fail).
  2. Create the activity before sending the email - otherwise you can have a situation that an email sent but then something crashed before the activity could be created and it looks like no email was sent.
  3. Move the email activity creation code into it's own class so the main "send" function is cleaner.
  4. Add CC/BCC information to the email activity so we can see if it was CC/BCC'd.
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: extensions/emailapi!17
Source branch: emailactivity