@monish.deb @seamuslee Did you have a chance maybe to take a look at this?
@monish.deb My other reason (besides that I've already mentioned) for making modified_date
the default was to avoid the need of parameterizing the ...
@semseysandor sorry for the delay due to the different timezone. So the original request was, they want to remove the delivered/completed mail from...
I see your point, however, is there any use-case when someone would want the original functionality? I mean, we could make modified_date
the defaul...
I agree with this proposal given that additional parameter modified_date
should be optional. In that way it won't break the original functionality ...
-
f99d27ce · Merge branch 'fix_cronjob_reverting' into 'master'
- ... and 1 more commit. Compare 79465b3b...f99d27ce
-
79465b3b · Merge branch 'optimize' into 'master'
- ... and 2 more commits. Compare 9e0a5d8f...79465b3b
Yep looks good to me too. Tested on my local. Merging now.
@monish.deb I think this makes the code more efficient here do you agree with the change here cc @Edselopez @semseysandor
@semseysandor I don't have a strident objection to this proposal, I will check with my colleagues who initially developed this extension to get the...