Skip to content
Snippets Groups Projects
twowheeler@hcpac's avatar
opened issue #3 "Deletemailings.cleanmailing doesn't run" at Extensions / deletemailings
Sandor Semsey's avatar
commented on merge request !6 "Deletemailings.CleanMailing don't delete A/B test mailings" at Extensions / deletemailings

@monish.deb @seamuslee Did you have a chance maybe to take a look at this?

Sandor Semsey's avatar
opened merge request !6 "Deletemailings.CleanMailing don't delete A/B test mailings" at Extensions / deletemailings
Sandor Semsey's avatar
opened issue #2 "Deletemailings.CleanMailing deletes draft A/B testing mailings, A/B test page won't load" at Extensions / deletemailings
Sandor Semsey's avatar
commented on issue #1 "Deletemailings.CleanMailing should use modified_date to select drafts to delete" at Extensions / deletemailings

@monish.deb My other reason (besides that I've already mentioned) for making modified_date the default was to avoid the need of parameterizing the ...

Monish Deb's avatar
commented on issue #1 "Deletemailings.CleanMailing should use modified_date to select drafts to delete" at Extensions / deletemailings

@semseysandor sorry for the delay due to the different timezone. So the original request was, they want to remove the delivered/completed mail from...

Sandor Semsey's avatar
commented on issue #1 "Deletemailings.CleanMailing should use modified_date to select drafts to delete" at Extensions / deletemailings

I see your point, however, is there any use-case when someone would want the original functionality? I mean, we could make modified_date the defaul...

Monish Deb's avatar
commented on issue #1 "Deletemailings.CleanMailing should use modified_date to select drafts to delete" at Extensions / deletemailings

I agree with this proposal given that additional parameter modified_date should be optional. In that way it won't break the original functionality ...

seamuslee's avatar
pushed new tag 1.2 at Extensions / deletemailings
seamuslee's avatar
deleted branch fix_cronjob_reverting at Extensions / deletemailings
seamuslee's avatar
accepted merge request !4 "Fix issue where cronjob parameters were reverting when system flush api was run and also prevent non int values being passed through which also caused problems" at Extensions / deletemailings
seamuslee's avatar
pushed to branch master at Extensions / deletemailings
seamuslee's avatar
deleted branch optimize at Extensions / deletemailings
Monish Deb's avatar
accepted merge request !5 "Optimize Deletemailings.CleanMailing: fetch only old mailings" at Extensions / deletemailings
Monish Deb's avatar
pushed to branch master at Extensions / deletemailings
Monish Deb's avatar
commented on merge request !5 "Optimize Deletemailings.CleanMailing: fetch only old mailings" at Extensions / deletemailings

Yep looks good to me too. Tested on my local. Merging now.

seamuslee's avatar
commented on merge request !5 "Optimize Deletemailings.CleanMailing: fetch only old mailings" at Extensions / deletemailings

@monish.deb I think this makes the code more efficient here do you agree with the change here cc @Edselopez @semseysandor

seamuslee's avatar
commented on issue #1 "Deletemailings.CleanMailing should use modified_date to select drafts to delete" at Extensions / deletemailings

@semseysandor I don't have a strident objection to this proposal, I will check with my colleagues who initially developed this extension to get the...

Sandor Semsey's avatar
seamuslee's avatar
opened issue #1 "Deletemailings.CleanMailing should use modified_date to select drafts to delete" at Extensions / deletemailings