Skip to content
Snippets Groups Projects

Fix aggregation on custom data

Closed David Hayes requested to merge dave/dataprocessor:fix_aggregation_on_custom_data into master

Merge request reports

Approval is optional

Closed by jaapjansmajaapjansma 4 years ago (Dec 8, 2020 4:28pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This might be the fix but something in me tells me there is a more elegant solution possible. I will have a look at another time at this

    ps. My personal opinion is that under the hood the data processor extension is too complex.

  • Author Contributor

    I agree. I was not sure how to approach this. Since custom fields have their own specification, I almost went for a new aggregation custom fields specification, however that seemed over kill for modifying one string.

  • Fixed with another fix. One was by using the function getName in AggregateFunctionFieldSpecification::convertFromFieldSpecification

    And the other fix was an issue with name the subquery data flow in the contribution data source.

  • closed

  • Author Contributor

    Fantastic!

Please register or sign in to reply
Loading