Skip to content
Snippets Groups Projects

Fix use of retrieve so we don't get undefined methods if parameters are not defined.

Merged mattwire requested to merge mattwire/dataprocessor:fixundefinedmethods into master

All of these CRM_Utils_Request::retrieve() instances are retrieving URL parameters. If the URL parameter does not exist it tries to retrieve via $this but if get() does not exist on $this it crashes with undefined method.

Eg. Error: Call to undefined method CRM_Contact_Selector_DataProcessorContactSearch::get() in CRM_Utils_Request::retrieve() (line 94 of /home/matthew/buildkit/build/d7master/web/sites/all/modules/civicrm/CRM/Utils/Request.php).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading