first draft adding contact acl to data processor
Merged
requested to merge michaelmcandrew/dataprocessor:25-hook-civicrm-aclwhereclause-for-dataprocessor into master
WIP for #25 (closed).
@jaapjansma - let me know what you think.
Merge request reports
Activity
mentioned in issue #25 (closed)
Cool - is there anything else you would want me to do before it is ready to be merged? One thing I haven't done is remove the ACL filter.
Reasons to do so:
- this should do anything that that filter did
- its confusing to have two approaches
- that one breaks in a few circumstances
Reasons not to do so:
- people might be using it
Suggested way forward:
Remove it and add an upgrade warning.
@michaelmcandrew I am in favour of leaving the ACL filter in place. That is because it might be in use. We might change the label though and add DEPRECATED to it.
Could you also update CHANGELOG.md and add the new source you created?
mentioned in commit acf17ff6
Please register or sign in to reply