Custom link field does not get outputted as HTML via API output

Steps to reproduce

1. Create a dataprocessor and add a custom link field
2. Set API output
3. Use API explorer to view the result (came across the issue when using Content Views CiviCRM )

Actual Result

As seen from the screen shot, the field only outputs the link text

mentioned in merge request !60 (merged)

added PR !60 (merged)

mentioned in commit a555f4b5

I did merge your MR at first and then reverted it because I had some thoughts.

There is a reason we dont use the html output in the api. The reason for that is in the API we want to deal with the raw values as the api outputs data which a computer can understand and this computer can then reuse this.

So the solution to this problem might be to replace (CustomLinkFieldOutputHandler.php:92](https://lab.civicrm.org/extensions/dataprocessor/-/blob/master/Civi/DataProcessor/FieldOutputHandler/CustomLinkFieldOutputHandler.php#L92) In that line the raw value is set the value of field, we could set the url here.

@jaapjansma in that case I'm gonna leave it for you. Cause as I see now, the getfields API doesn't return the field output type. More modifications will be needed and the WordPress plugin will also need to be updated

mentioned in commit 29caa485

I have fixed it. Can you test this? The getfields api should return the type of the field in type = 2 and data_type = 'String'

@jaapjansma tested and works. Thanks.

I mean it doesn't return the field type if it's a custom link or raw value etc.

if the API returned that as well, then it just needs to return the URL without the html and other systems can format the URL as they want. It will be easier to distinguish between a normal text and a URL

The getfields api is a standard civicrm api. And the type and date_type are standard CiviCRM types and CiviCRM does not have a type for the URL.

Yep so for a third party, it's difficult to distinguish the real field type without having to do a string match, which is unreliable.

Civi does have a "Link" data type for custom fields

CRM_Core_BAO_CustomField::dataType()

@jaapjansma I am happy with the fix for now, so closing it. Thank you for the help. Really appreciate your awesome work

closed

Ah I did not know about the data type of Link. I used the list from here: https://github.com/civicrm/civicrm-core/blob/cd20264ca53a5d9d49672ba690019f69c9e3823e/CRM/Utils/Type.php#L144

oh okay. Hope you can enhance the extension bit more. Probably add a new field to display images as well. Just a suggestion.

If you use raw field output and select the image field then the data processor outputs the url of the image.

hmmm it didn't work for raw field output. For some reason it's outputting the value as "1".

Custom field :

Field config :

API result :

But changing the field to File Download Link and checking "Only return URL" did work. In any case, I would have to modify the WordPress plugin for it to output as an image.

I added an image field output handler, if it's any use at all

ImageFieldOutputHandler.php

ImageFieldOutputHandler.tpl

That is a nice addition indeed. Can you create an merge request for that?

mentioned in merge request !61 (merged)

added an MR :)

mentioned in commit b5607eb7

mentioned in merge request !64 (merged)

mentioned in commit bf9cf803