Skip to content
Snippets Groups Projects
Commit 7ae9c23e authored by jaapjansma's avatar jaapjansma
Browse files

Join when aggregation is enabled on a data source should be of type LEFT and not INNER.

parent e221d840
No related branches found
No related tags found
No related merge requests found
......@@ -7,6 +7,7 @@
* Fixed issue with aggregation fields and a subquery data flow.
* Fixed issue with backwards compatibility and field drop down.
* Fixed issue with date filter and civicrm version before 5.25
* Join when aggregation is enabled on a data source should be of type LEFT and not INNER.
# Version 1.24.1
......
......@@ -222,7 +222,7 @@ abstract class AbstractCivicrmEntitySource extends AbstractSource {
$groupByFields[] = $field;
}
$join = new SimpleNonRequiredJoin($entityTableAlias, $this->getAggregateField(), $this->aggregationDateFlow->getPrimaryTableAlias(), $this->getAggregateField(), 'INNER');
$join = new SimpleNonRequiredJoin($entityTableAlias, $this->getAggregateField(), $this->aggregationDateFlow->getPrimaryTableAlias(), $this->getAggregateField(), 'LEFT');
foreach($groupByFields as $groupByField) {
$join->addFilterClause(new PureSqlStatementClause("`{$entityTableAlias}`.`{$groupByField->alias}` = `{$this->aggregationDateFlow->getPrimaryTableAlias()}`.`{$groupByField->alias}`", TRUE));
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment