Skip to content
Snippets Groups Projects

pass 'contribution_id' as 'contributionID' as well

Open JonGold requested to merge JonGold/contributiontransactlegacy:contributionID into master

Should this extension be dead already? Yes. Is it? Sadly not.

When using authorize.net (legacy processor) with Webform-CiviCRM, you get this error:

It appears that this transaction is a duplicate. Have you already submitted the form once? If so there may have been a connection problem. Check your email for a receipt from Authorize.net. If you do not receive a receipt within 2 hours you can try your transaction again. If you continue to have problems please contact the site administrator.

This is because the dupeCheck() is looking for contributions that have the same invoice_id but aren't the contribution specified in $params['contributionID']. But the ID is passed in from this extension in $params['contribution_id']. So the dupe check finds the pending contribution and returns this error. So now we pass in the ID with both array keys.

I believe the authnet extension suffers from a different failure on the dupe check. I'm confirming that in a few minutes, and may submit a PR there as well.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading