Civirules api action exception: Unable to remove/add tags.

mentioned in issue #15 (closed)

changed title from Master to Civirules api action exception: Unable to remove/add tags.

I dont get it why this working. If the api call EntityTag getvalue fails it gets into the catch part. My assumption is that it fails because the record does not exists in the system anymore.

So what is the if statement checking? What happens when the if staement evaluates to false?

Use case:

Action -> Delete:

1. Check if a contact is already tagged.
2. If yes then api will return id and contact will be removed from tag
3. If No api will throw exception and will go into catch part and it will skip the foreach loop and move to next as we don't need to perform delete since the contact is not tagged

Action -> Add

1. Check if a contact is already tagged.
2. If yes then api will return id and then it will go in if statement, So we don't need to add contact to tag which has been already tagged so skip the foreach loop and move to next.
3. If No api will throw exception and will go into catch part and won't go in if statement since action is create so it will create entry entity tag table.

EntityTag api throws exception when you try to perform delete action when contact is not tagged. This PR solves the problem as it checks before sending it to CiviCRM api.

I see why I was confused I forget that your changes are within a foreach a loop.

merged

mentioned in commit 26b28d66

Thanks @pradeep

My Pleasure :)