Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C civirules
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 45
    • Issues 45
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • civirules
  • Merge requests
  • !191
The source project of this merge request has been removed.

Add Activity action: remember send_email "no" selection

Merged Sandor Semsey requested to merge (removed):activity-send-email into master Nov 21, 2022
  • Overview 1
  • Pipelines 0
  • Changes 1

Before

When editing 'Add activity to contact' action, selecting 'No' on 'Send Email to Assigned Contacts' is saved, but when opening this screen again the selection got "forgotten". This is quite annoying as it is a required field.

After

Setting 'No' on 'Send Email to Assigned Contacts' is remembered.

Technical

send_email is stored as "0". When setting defaultValues for the form !empty($data['send_mail']) is false, so default value is not set for this field. Changed it to the null coalescing operator.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: activity-send-email