Skip to content

fix 'Contact has recurring contribution' condition

JonGold requested to merge JonGold/civirules:recurring-contribution-fix into master

The "Contact has recurring contribution" condition was broken in two ways:

  • It was looking for the end_date field in the API3 results. However, the end_date isn't part of the ContributionRecur API results. I'm guessing this is a regression, or this condition would never have worked. It's present in API4 though.
  • The description of the end date is "Date this recurring contribution finished successfully". However, someone whose recurring contribution was cancelled or failed shouldn't be considered to have an active recurring contribution - especially since in my experience most recurring contributions are open-ended and must be cancelled to end them.

Merge request reports

Loading