Control Discount on New or Existing Membership

Created by: sunilpawar

Before

We can not set discount for New or Renewal Member only

After

We can set discount code for New and/or Renewal member only.

Comments

Issue #230 Closed PR : #231

restored source branch github/fork/sunilpawar/issue-230-new

cc @sunil (for notifications on future activity)

@bgm who is taking care of PR review?

@sunil I don't think there is a maintainer at the moment, see #273 (closed) (edit: mattwire and coleman seem to be doing most of the review)

@sunil are you still looking to work on this? I've had a quick look, but won't do a full review until I hear from you. One thing I would say is we need to make sure these would both be set to true for existing discounts so there is no behaviour change on upgrade for those. I think having both true by default would make sense for new discounts too.

@larssg you want default true in table or in checkbox only ?

if we keep false value (both checkboxes) for existing records then original behaviour will continue until the admin changes the setting.

@larssg , ah , got it, i will fix git conflit and set default value to true for existing record.

Sorry it's taken so long for you to get a response on this @sunil - this extension has been looking for a maintainer for a while. We're fortunate that @larssg is plowing through the issues right now.

I'm curious about the logic of these 2 new columns. If they are both true then all memberships will be processed (that match other criteria). If one or the other is true then only new/existing membership will be processed. But what if they are both false? That seems like a non-sensical setting.

I'm also curious to know if you considered storing this in the filters column. It looks like filters is a json array of api params, which might be used for this purpose instead of adding 2 new columns.