CiviDiscount, Discounts for events, the option "Any event" does not work

Created by: agileware-justin

Using CiviCRM 5.40.1, CiviDiscount 3.8.4 and WordPress 5.8.

Steps to reproduce

1. Create a Discount Code
2. Set a discount amount
3. In the section "Discounts for events", select Events: "-- any event ---"
4. Go to an Event Registration form, try locate the Discount Code field on the form.
5. The Discount Code field is not shown on the form.

Discounts for events with the option "-- any event ---" does not work.

Workaround The workaround is to select all the available Event Types, then the discount is available for all events and it can be applied.

Agileware Ref: CIVICRM-1774

Created by: lkuttner

Please describe the behavior that you are seeing when you try to use it. "does not work" is not sufficiently descriptive .

Created by: agileware-justin

Have moved this comment to the main issue description.

Created by: lkuttner

This appears to be related to the issues that I am seeing on our dev server after updating to 3.8.4. I am not seeing events in the event list for new Price Sets or ones that have been created since changes were made to Price Sets around two years ago. It appears that changes have been made to possibly both Price Sets and CiviDiscount that are not cross-compatible. See my comments dev/core#2727 (comment 62628) and dev/core#2727 (comment 62692) in this other issue with automatic discounts not being applied.

Created by: gibsonoliver

Also seeing exactly the same issue. Checked on 2 different sites

Using CiviCRM 5.40.1, CiviDiscount 3.8.4 and WordPress 5.8.

Steps to reproduce

1. Create a Discount Code
2. Set a discount amount
3. In the section "Discounts for events", select Events: "-- any event ---"
4. Go to an Event Registration form, try locate the Discount Code field on the form.
5. The Discount Code field is not shown on the form.

Discounts for events with the option "-- any event ---" does not work.

Workaround The workaround is to select all the available Event Types, then the discount is available for all events and it can be applied.

Agileware Ref: CIVICRM-1774

Created by: agileware-justin

I don't think this extension is currently being maintained @gibsonoliver - see https://github.com/civicrm/org.civicrm.module.cividiscount/issues/273 - looking for new maintainers

How about we just remove the "Any event" option from the list of Events. It clearly does not work currently and no one so far has stepped up to fix it. So why have an option which does not work?

Update: we're just going to go ahead and do that. It's causing too many support requests.

I tend to agree with @justinfreeman that 'Any Event' is not necessary and if I recall correctly 'Any Event' it was not an option until the last few years. I am checking on a site that has used CiviDiscount since 2012 and many of their past discounts the Event field is simply blank, and these discounts were available for any event, and the discounts were used many times according to the log. Why was "Any Event" added?

mentioned in commit justinfreeman/cividiscount@e315a9fb

mentioned in merge request !273 (closed)

@Stoob this is the change we use in production, !273 (closed)

It does work if you select event types as well. I propose changing the event types to default to "all" if none are selected. On busy sites (eg. 100s of events) it does not make sense to have to add every event to that list when you want a discount to apply to all events.

Thanks @mattwire I think your proposal is reasonable

It does work if you select event types as well.

That's good to know!

I propose changing the event types to default to "all" if none are selected.

Agreed, go for it @mattwire

I fixed it

!285 (merged)

closed

changed the description