Option to set a campaign for each journey which is then assigned to CiviMails

Created by: ufundo

For this feature: https://github.com/artfulrobot/chasse/issues/22

Created by: ufundo

Sorry I don't know why the permissions code in chasse.php is showing in the diff. I thought this was already merged into your master @artfulrobot - probably a git snafu on my part?

Created by: artfulrobot

Hi @ufundo thanks for the PR. Seems sensible, however not everybody has CiviCampaign enabled. Can you add autodetection of that so it's safe for those installs?

And yes, I think you need to remove the permissions changes. Perhaps you didn't update your master to mine before branching and committing your working tree?

Thanks

Created by: ufundo

Hi @artfulrobot - sorry took a while to come back to this!

Permissions edits removed.

For handling situation with no CiviCampaign, I have:

1. wrapped the bit of the config page to only display when CiviCampaign is enabled and there are campaigns to choose from
2. tweaked the mailing code to avoid throwing php notice if campaign_id is not set for journey

I haven't: 3. disabled passing an existing campaign parameter to CiviMail when CiviCampaign is disabled

This means if you start with CiviCampaign enabled, configure a campaign for a mailing, and then disable CiviCampaign, CiviMails will continue to be linked to the campaign in the background even while CiviCampaign is disabled. They will show as such if you later re-enable CiviCampaign. This seems sensible behaviour to me (and keeps the code simple!) but wanted to flag as potentially debatable?

Created by: artfulrobot

@ufundo this looks good, I've not had chance to test it yet though.

I don't see the need for https://github.com/artfulrobot/chasse/pull/24/commits/44e1e6fb7057cd6641ef73a3ff6ad6ce90dea887 though - I think it's quite important to know what's gone on in the logs. Perhaps you felt there would be enough data elsewhere or something?

Created by: ufundo

Hey, thanks.

44e1e6f was an extra (commented) debug log I'd introduced myself, so was just removing to reduce the diff from your master

Created by: ufundo

Hi @artfulrobot - just to flag I've rebased and cleaned up the previously-icky commits on this!

restored source branch github/fork/ufundo/journey_campaigns

@ufundo sorry, it seems this one got forgotten about. I have recently merged an overlapping MR from @kurund.

I'll close this for now, as a new MR would be needed.

@kurund - did you see this before doing your work? Seems like it also adds the campaign to the mailings it creates.

closed