Skip to content

test only - fix ordering when comparing inkind values

DaveD requested to merge DaveD/cdntaxreceipts:order into master

We were probably lucky before, that the order we're comparing against in the test matched the order the custom fields are created in. Another way would be to change cdntaxreceipts functions to use an associative array instead of numeric (e.g. here https://lab.civicrm.org/extensions/cdntaxreceipts/-/blob/5355581817412a5b0bd710de2228e930e868552b/cdntaxreceipts.functions.inc#L451)

Likely https://github.com/civicrm/civicrm-core/pull/31569/files has inadvertently changed the (previously arbitrary and now probably still arbitrary) order of CustomField.get when you don't specify an order.

Edited by DaveD

Merge request reports

Loading