Skip to content

Improve UX for the In-kind setting

DaveD requested to merge DaveD/cdntaxreceipts:inkind-setting into master

It's a strange bird. It's a checkbox that's always unchecked.

This includes !184 (closed) as the first commit because it depends on it.

So now you'll see one of three things:

  1. The original checkbox, if you've never configured In-kind. I've just changed the help text since it didn't make sense. new
  2. If you've configured it prior to the unreleased version, and then also changed the name of the financial type prior to the unreleased version, the upgrade won't be able to figure it out. But it knows about the custom fields. So then it displays a dropdown for you to select the right financial type. There's also a status check directing you here. missing
  3. If it's all configured, then it just displays a confirmation of such, with some help text taken from the original. configured

Also as a bonus fix there's a longstanding weirdness when saving the settings page where it redisplayed the form but didn't show your recent changes.

Merge request reports