Add autocomplete for bank account
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- wmortada created branch
4-add-autocomplete-for-bank-account
to address this issuecreated branch
4-add-autocomplete-for-bank-account
to address this issue - wmortada mentioned in merge request !3 (merged)
mentioned in merge request !3 (merged)
- wmortada changed the description
changed the description
- wmortada mentioned in issue shares#19 (closed)
mentioned in issue shares#19 (closed)
- Maintainer
looks good @wmortada
Collapse replies @michaelmcandrew This is ready now. Feel free to merge or let me know if you have any questions.
- wmortada assigned to @michaelmcandrew and unassigned @wmortada
assigned to @michaelmcandrew and unassigned @wmortada
- Maintainer
@wmortada one thing I am wondering about is whether it makes sense to package this auto complete in the shares extension rather than here.
We talked about implementing an event listener to allow for that. I can see that you have implemented some event related stuff but haven't dug into the detail. Might be worth a quick call to discuss?
- wmortada assigned to @wmortada and unassigned @michaelmcandrew
assigned to @wmortada and unassigned @michaelmcandrew
@michaelmcandrew as discussed I've stripped out the CiviShares specific functionality for a simpler default autocomplete.
!3 (merged) is ready to merge.
- wmortada assigned to @michaelmcandrew and unassigned @wmortada
assigned to @michaelmcandrew and unassigned @wmortada