Skip to content

Skipped merges are appearing as successful

shaneonabike requested to merge (removed):master into master

I had though that my merges were working properly until later realizing they were being skipped. I had previously run it in simulation mode and ignored all the proper elements, but it was still having trouble. This makes it a bit clearer in the logs.

The Issue

When running an autodedupe the actual array returned looks like this

array (
  'merged' => 
  array (
  ),
  'skipped' => 
  array (
    0 => 
    array (
      'main_id' => 17582,
      'other_id' => 149686,
    ),
  ),
)

With either the ids appearing in the merged array or skipped if it is in the skipped section. Otherwise, if there is a total error then it will return nothing in results or null.

Solution

Provide a bit more feedback on skipped items so people don't think they are actually being merged

cc @bgm

Merge request reports