Skip to content

Draft: Remove `composer.lock`?

xurizaemon requested to merge 17-remove-composer-lock into main

I revisited this extension after a few years and was surprised it had a composer.lock committed - that's not my expectation of how an extension would work, I'd expect a single top-level .lock file which is generated for the site/project and resolves dependencies for all components in it.

To understand what's normal practice in CiviCRM space, I had a look at a handful of extensions which showed up in a search for composer.json

One had a composer.lock as well, and most didn't. So I'm filing this PR to remove composer.lock, but I'm not in a position to test the extension, so we should wait until someone gives it the 👍 before proceeding. Hence Draft: prefix.

There's also extensions-directory#9 which suggests there's not a clear rule here yet. I didn't find anything in the docs yet.

Related: https://lab.civicrm.org/xurizaemon/org.civicrm.contrib.anonymize/-/merge_requests/20

Edited by xurizaemon

Merge request reports

Loading