Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • A action-provider
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • action-provider
  • Merge requests
  • !62

Support start/end dates on relationship create/update; related fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged JonGold requested to merge JonGold/action-provider:relationship-dates-fixes into master Oct 12, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

This supports relationship start/end dates on "Create or Update Relationship" and fixes some related logic errors.

Support Start/End Dates in "Create or Update Relationships"

  • getParameterSpecification() is identical in both CreateOrUpdateRelationship and CreateRelationship which it extends, so I removed getParameterSpecification() from the former.
  • Added handling of the start/end dates in CreateOrUpdateRelationship::doAction().
  • Improved label of "Set Start Date?" to "Set Start Date to Today?".

Fixed logic errors

  • In createRelationship(), if you enable "Set Start Date", it ignores both the Start Date and End Date parameters. I modified it to only ignore the Start Date parameter.
  • In createOrUpdateRelationship(), if an existing relationship is found, the end date is set to NULL. I don't think this is intentional, but if it is, I can put it back.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: relationship-dates-fixes