Regression analysis 5.2.0 (fixed 5.2.2)
What happened? A pro-bono bug fix to help Webform users add payments to events resulted in part of the back-office event registration screen not loading for Wordpress users.
How & When was it addressed Patch release 5.2.2 released within 48 hours on the bug being logged in gitlab. Pradeep gets credit for analysing the bug and submitting the fix after doing some pretty careful analysis of a confusing stack exchange report. Kevin tested the fix for us (very promptly)
How did the regression fit with our processes?
The original fix was tested by multiple people and it appeared to work. All those people were on drupal but there was nothing about the fix that implied there would be any difference for drupal vs another CMS. However, it turned out that drupal was in some way ‘swallowing’ the errors’.
The bug was fixed within 48 hours of being logged in github. It was asked first in stack exchange and Pradeep picked it up and submitted a fix. There was an earlier confusing question logged in stackexchange which was probably the same bug.
Context This bug was registered first on stack exchange - but there is considerable confusion (still) on how tightly the stack exchange issue maps to the bug. A lot of credit is due to Pradeep for determining that there was a bug in the description there and figuring out how to replicate it. I looked briefly at that issue as it had 5.2.1 in the description but did not figure out that there was a replicable bug in there.
Recommendations going forwards
- Figure out how to make our buildkit drupal environments less forgiving. The goal should be that dev environments are the least forgiving environments and production the most and this analysis identifies an instance where that was not the case
- Think about how we can more quickly identify stack exchange issues. In this case it was Pradeep’s effort that got us there. (We can’t realistically stretch the existing product maintenance team to spend more time on Stack Exchange).
Update Buildkit now has stricter error checking for drupal by default.