Skip to content

Docker support and more

Sean Colsen requested to merge gh-725bfd5d/64/mickadoo/master into master

Created by: mickadoo

Description

Unfortunately this PR is one that spans a few different topics. I had a look over the code and tried to:

  • Clean up composer.json, allowing compatibility with PHP7
  • Remove the default Symfony tests and create a test structure that we can hopefully use going forward
  • Add a Dockerfile with the aim of allowing new users to easily set up the app for local development
  • Add a pull request template

Before

No docker support, license had different names, trying to install on PHP7 just failed.

After

This pull request template for one thing. It should be easier for new contributors to set up locally if using docker. PHP7 should be supported and we have actual tests that cover some of the code.

  • Tests pass

Merge request reports

Loading