[Joomla 4.0] CiviCRM logo not showing in Quick Icon plugin

Very low priority, but the QuickIcon Joomla plugin (https://github.com/civicrm/civicrm-joomla/tree/master/admin/plugins/civicrmicon) no longer shows a Civi logo:

changed milestone to %Joomla 4 Integration

changed title from CiviCRM logo not showing in Quick Icon plugin to [Joomla 4.0] CiviCRM logo not showing in Quick Icon plugin

Thanks @nicol for noticing this and reporting it. Are you able to provide a fix?

added git:civicrm-core git:civicrm-joomla sig:usability triaged labels

removed git:civicrm-core label

I did take a look comparing it with the other new Joomla quickicon plugins (https://github.com/joomla/joomla-cms/tree/4.0-dev/plugins/quickicon) and it seemed quite a bit had changed in their structure, so it's not something I could do quickly (if at all). Also I'd probably need to figure how to keep it J3 backwards compatability, unless we jsut created a new quickicon plugin for 4 (which could at least duplicate the new structure) and then add a conditional in the installer/upgrader somewhere.

Given #35 (closed) (and not a blocker but still a bug, this: #16) – it seems the lowest of the Civi Joomla 4 issues, on the edge of being issue-worthy!

Thanks @nicol no problem! Thanks for all your effort!

added sig:joomla label

@monish.deb please proceed to use the new J4 approach.

I'm under the odd impression that we think we can use the same tarball of CiviCRM for both J3 and J4. If this is indeed the case prior to working on this issue, then let's go the extra bit to make this compatible with both.

I have submitted a PR https://github.com/civicrm/civicrm-joomla/pull/65 which handles both J3 and J4. @nicol can you please review my PR?

@monish.deb happy to. I've not tested parts of Joomla pre-build locally before - could you point me to any docs or advice on how to turn this: https://github.com/JMAConsulting/civicrm-joomla/tree/j4_quickicon_fix - into something I can install/run locally? Or do I just install the latest Civi on J4, and manually patch the changed files from this fix?

@nicol I would recommend the latter approach to get a freshly installed or existing instace with latest Civi + J4. You can then apply the patch from the PR I mentioned above, for detail please check this link

assigned to @nicol

Thanks @monish.deb. It works great and doesn't impact J3 quickicon either. I've just made a tiny PR for the background repeat if it's helpful, but otherwise will comment on the original PR.

ahh right, didn't noticed the small glitch. Thanks a lot for submitting PR against my branch, I have merged now :)

PR https://github.com/civicrm/civicrm-joomla/pull/65 is merged now. Hence closing the ticket

closed