Find Contributions searches on inaccurate, redundant payment fields
This problem is somewhat related to #37 in that there are redundant payment-related fields on the contribution record. That issue covers a record updating problem--when the contribution record isn't updated accurately to reflect the payment information. This issue is that the Find Contributions search looks only for the value in the contribution record.
When there are multiple payments by check, the check number field on the contribution is updated to have both numbers, separated by a comma. So, the check number is 111,222
if the first check is 111
and the second is 222
. Searching for a contribution with check numbers 111
or 222
will yield nothing, but searching for 111,222
finds it. Obviously this is a bug, but it might properly be considered a bug in search--the search should look among the payments, not the value on the contribution.
Again, like #37, the real solution is to ditch the redundant fields. However, in the meantime we should stop relying upon them.
It appears that card number works properly:
- Record contribution, pending pay later (setting payment method to be
Credit Card
to sidestep the problem in #37) - Record payment for part of the amount, payment method
Credit Card
with the card ending in1234
- Record payment for the remainder of the amount, payment method
Credit Card
with the card ending in6789
- Find contributions, payment method
Credit Card
, card number1234
, retrieves the contribution. - Find contributions, payment method
Credit Card
, card number6789
, retrieves the contribution.
Since there is no card number on the contribution, the search is forced to work the right way.