Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F Financial
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Development
  • Financial
  • Issues
  • #183

Closed
Open
Created Aug 25, 2021 by KarinG@KarinGMaintainer

Order API is not Order AI

[copied notes from Mattermost]

Towards 'making this sane' and could be implemented immediately -> for example - one would be to immediately start returning ->

a notice -> 'warning: incompatible set of input params - Order API can not create coherent line-item(s)'.

When being presented with incompatible data -> e.g. if total_amount = 10; tax_amount = 0.25; financial_type_id = 1;

That's an impossible set of input params. Yes - they are still being handled right now - but results will be unpredictable b/c it is simply impossible to create a co-herent line_item with those input params.

I have some more notes in 21187 - will park them in my own atrium for now. Key one is that one 👆

Another one could be that if presented with line_items and a total_amount at the Contribution level - then that all better be adding up or else ->

a notice -> 'warning: incompatible set of input params - Order API can not create coherent line-item(s)'.

At this stage the API can still attempt - but alerting people would be a first step towards to no longer accept incoherent input. Order API is not Order AI :-)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking