Clicking orange Paypal Button with Paypal Pro results in form validation jquery error

Reproduce by:

1. setting up Paypal Pro processor
2. clicking the orange button should send you to Paypayl.com to login instead of paying by card
3. instead it immediately triggers the jquery form validation required fields for card

mentioned in issue #144

added regression label

@Stoob do you know what version it worked in? At some point we enabled jquery validation (I feel like that was a while back) & then some fixes were done - so the issue could stem from either

Yes, I believe it worked in 5.26. We recently updated to 5.28 and it stopped working. @eileen

agh ok right now i understand the problem here. so with PayPal Standard should the credit card fields even show up or is it like PayPal checkout or enter your credit card details? @Stoob (a bit of a noob on the whole Paypal Standard v pro stuff here)

That is correct. When using Paypal Pro, Paypal as a corporation requires the orange button as an option for folks who prefer to pay via their Paypal account anyway, rather than entering a credit card. The process when clicking the orange button is similar to as if using Paypal Standard. But Paypal Pro (also known as Paypal Website Payments Pro) is a different processor than Paypal Standard. It is also a legacy processor that Paypal doesn't like to sign people up for anymore. Is that helpful background?

@Stoob wondering if your able to test https://github.com/civicrm/civicrm-core/pull/18459

I've tested @seamuslee and it works thanks.

Interestingly the reCaptcha is still required in order to click the orange Paypal button. I am not sure that is necessary but I wouldn't call it a bug, per se. Probably better safe than sorry and have the reCaptcha be always required.

@Stoob did you test on 5.29?

No I patched 5.28

OK - we have tested on 5.28 & 5.30 so that should cover 5.29 as the button change is in master anyway

mentioned in commit core@67afda37

mentioned in commit core@dab84a0f

Just wanted to raise awareness that Paypal's own reCaptcha may be mangling our link, or the link Civi is forwarding to Paypal is incorrect. This appears to happen only when Paypal presents its own reCaptcha, which it only does if it doesn't recognize you (no cookies) so it may be an edge case.

• I was able to click on the Paypal button fill out to captcha on Civi
• then fill out the Paypal captcha on Paypal.com
• then I got a failure page "server not found".
• The URL shown was: https://cgi-bin/webscr?cmd=_express-checkout&token=EC-01N870270Y498870C&Z3JncnB0=

@Stoob I want to close this against the fix - create a new GL?

I cannot reproduce the error with Paypal's recaptcha on more than one computer, that isn't my own. If we can get there, I will repost another issue.

Please close this issue @eileen and thank you

mentioned in commit core@e3e81d58

mentioned in commit core@11d000e6

changed milestone to %5.29.1

closed