CiviCRM session instance not working when Masquerading in Drupal 7

Have just upgraded to D7-5.20.1 and noticed that CRM_Core_Session::singleton() does not work when masquerading.

Setting a breakpoint in a Drupal page while masquerading and running Civi::log()->debug(var_export(CRM_Core_Session::singleton(),true))

Results in the following in the log:

Dec 11 13:08:57  [debug] CRM_Core_Session::__set_state(array(
   '_key' => 'CiviCRM',
   '_session' => 
  array (
    'masquerading' => '76',
  ),
))

changed milestone to %5.21.0

mentioned in issue #54 (closed)

@michaelmcandrew Not finishing your subject lines is a sign of

(grin)

Here are some things I think you might have meant:

"Masquerading not working in"

1. ... Internet Explorer.
2. ... these monkey-fighting sites on this Monday to Friday plane.
3. ... drupal 7 civicrm 5.20

changed title from Masquerading not working in to CiviCRM session instance not working when Masquerading in Drupal 7

thanks @DaveD - have updated the subject line

Hi, I am testing civicrm 5.20.2 + Drupal 7.68 (with CAS module) and I have a similar problem. The Civicrm session object does not contain variables (userID, ufid etc...). (This is a critical issue for authentication...)

This is related to this patch added into drupal core 7.68: https://www.drupal.org/files/issues/2019-11-04/3025335-51.patch (revert it fixes the issue but display a warning with PHP7.3)

added git:civicrm-core git:civicrm-drupal regression sig:bug triaged labels

I have given this the regression label because this sounds like a regression to me. Feel free to remove that label when you think it is not a regression bug.

This seems like a regression from a drupal update rather than civi - but I guess we need to adapt our code to cope with their change

I have spent more time on this issue and have created a patch (that fixes the issue on my side). As of Drupal 7.68, drupal_session_regenerate() can close the PHP session and create a new one : a new $_SESSION variable is instantiated. So we need to update the reference to $_SESSION in CRM_Core_Session.

fix-regenerated-session-ref.patch

I turned it into a PR https://github.com/civicrm/civicrm-core/pull/16177

Aside wrt target version: I think it'd be fair-game to fix compat w/Drupal 7.68 in a 5.x.y patch update. The main thing is that the patch touches code which is a bit dicey (central/shared, not a lot of test-coverage, sensitive to CMS/environment issues), so one wants pretty decent r-run coverage in diff environments. If no one is in a good position to do that for a 5.x.y patch... then +1 for going through master and a full alpha/beta cycle.

@totten might be a case for merging as soon as the rc is cut

@kcristiano should we merge ^^ now & give it a long merged cycle?

I think so. This will affect Joomla and WP as well

OK - I've merged it to master (which will be 5.23 release) - keep an eye out

closed

changed milestone to %5.23.0

mentioned in commit core@9b418792

mentioned in commit core@6524d35e

Thanks Eileen, I use masquerading all the time with WP so we'll test that. Does anyone here know how to masquerade in Joomla?

Just wanted to note the Australian Greens ran into an issue where the CiviCRM menu wasn't loading on 5.19.4 on initial login however loaded fine on refresh, Applying this PR seems to have fixed the issue.

mentioned in issue #163 (closed)