Drupal 8 profile validation not finding the right profile when validating submission on CMS user tabs

In drupal 8/9, like in drupal 7, the CMS user record by default has the Name and Address profile available for editing on the CMS side. As noted in passing at #117 (comment 40124) the validation for this form isn't working fully in drupal 8/9.

It appears to be a name vs label problem. The drupal 8 implementation uses the label to look up the profile. I have a quickie fix below but am mulling it over a bit since there's a lot of other things wrong with this form, e.g.

• #113 (closed)
• #117 (closed)
• core#2301 (closed)

index 37e7ead..b18bb04 100644
--- a/src/Form/UserProfile.php
+++ b/src/Form/UserProfile.php
@@ -75,7 +75,12 @@ class UserProfile extends FormBase {
     $this->profile = $profile;

     // Search for the profile form, otherwise generate a 404.
-    $uf_groups = \CRM_Core_BAO_UFGroup::getModuleUFGroup('User Account');
+    $uf_groups = \CRM_Core_BAO_UFGroup::getModuleUFGroup('User Account', 0, TRUE, \CRM_Core_Permission::VIEW, array(
+      'id',
+      'name',
+      'title',
+      'is_active',
+    ));
     if (empty($uf_groups[$profile])) {
       throw new ResourceNotFoundException();
     }
@@ -109,7 +114,7 @@ class UserProfile extends FormBase {
    * {@inheritdoc}
    */
   public function validateForm(array &$form, FormStateInterface $form_state) {
-    $errors = \CRM_Core_BAO_UFGroup::isValid($this->contactId, $this->ufGroup['title']);
+    $errors = \CRM_Core_BAO_UFGroup::isValid($this->contactId, $this->ufGroup['name']);

     if (is_array($errors)) {
       foreach ($errors as $name => $error) {

Relatedly, this seems an odd return value if it couldn't find the profile. Shouldn't it return an error? https://github.com/civicrm/civicrm-core/blob/a7b9631b60548092f8c3056c375dd4b81606dbd4/CRM/Core/BAO/UFGroup.php#L785

FYI @AlanDixon @spalmstrom

changed the description

added git:civicrm-drupal sig:bug triaged labels

I confess I don't really understand your patch, but I tried it anyway and it broke my site, so I undid it.

I believe the issue remains (i.e. the form will accept invalid input and fail silently).

I can confirm that the profile validation does not work on Drupal (9) user tabs with CiviCRM 5.41.1. The suggestion to pass ufGroup name instead of title solves the problem and the validation works as expected. Getting the group with

$uf_groups = \CRM_Core_BAO_UFGroup::getModuleUFGroup('User Account', 0, TRUE, \CRM_Core_Permission::VIEW, ['name']);

is sufficient since all other fields are passed by default.

If this fix breaks a site it seems not to be related to this change but might be another bug after the form validation or a misconfiguration.

Is there a PR for this?

It would be good to get more info on how it broke. If it was ResourceNotFoundException it could be something like on some sites the way the profile was created was different somehow and so it's not matching to name. Or possibly there is a drupal module installed that changes what $profile looks like. I wouldn't want to put up a PR if it might be a common configuration.

mentioned in issue core#2301 (closed)

I made an MR: https://github.com/civicrm/civicrm-drupal-8/pull/77. It is a variation of @DaveD and @fsnet suggestions. This works fine for me. It validates - no other bugs. I think we have squashed the other bugs so it's easier to see that this fix works.

It's funny that CRM_Core_BAO_UFGroup::getModuleUFGroup doesn't include the name by default since it's needed to find the right group for validation. That would be a useful MR for core (I might do that quickly).

added has-pull-request label

I also created https://github.com/civicrm/civicrm-core/pull/25336

mentioned in commit core@9dd72c2d

mentioned in commit core@bf339032

changed milestone to %5.59.0

closed