[unreleased regression] CiviCRM Admin Bar visible on 'Front End' of WP

Testing 5.12 rc. This version has integrated KAM.

When on a WP page on the front end we see:

As expected.

Go to a CiviCRM page, eithe a WP Page with a CiviCRM shortcode or directly and you see the CiviCRM admin Menu

There is no way back to the admin via the menu.

Randomly testing the menu items I had some work and send me to the back end, and some give 404s. Example Manage Contribution Page Link

Also confirmed on demo.wpmaster.civicrm.org

cc @colemanw

changed milestone to %5.12.0

added regression label

changed the description

So just to be clear @kcristiano - the status-quo expectation is that the menu does not appear on any front-end url.

@colemanw yes, the status quo is that the CiviCRM admin bar would not appear on the front end.

I do see now that the menu could be hidden, but it is unexpected behavior. I am also concerned that I am getting 404s based on user roles on wpmaster.demo.civicrm.org. I cannot reproduce that on my test site, but if we do want the CiviCRM menu to show on the front end, I'd want to do a great deal more testing with varying levels of CiviCRM roles/permissions.

mentioned in issue #797 (closed)

The funny thing is that in Drupal (which doesn't have a concept of FE vs BE paths) the menubar always appears on "public" civi pages and it's considered normal.

@colemanw I don't consider this normal and it's a major change. Especially as it takes over the wp-admin bar I do not think it should be on the Front End at all.

The new menu should follow the logic of the old one as far as where and how it's displayed from my perspective.

@colemanw I agree 100% with @kcristiano. This would be unexpected and unwelcome to my logged-in users.

@kcristiano In the meantime, here's a little plugin that removes the menu from the front-end until this is fixed.

@colemanw Further to my testing if you use a CiviCRM Page with a WP shortcode such as https://example.org/donate/ the menu items will try and use the donate slug for backend links.

I've been using 5.12 on many sites and the confounding part is sometimes the menu works on the front end, but mostly not. It only works if you are a full Administrator.

We should not be showing the CiviCRM menu on the WP front End.

I thin k we need to revert this or fix it. We cannot release this for WP in its current state.

added triaged label

added Doing label

@haystack thanks for the plugin, but a core PR would have been preferred.

I've done one for the RC here: https://github.com/civicrm/civicrm-core/pull/13820

changed title from CiviCRM Admin Bar visible on 'Front End' of WP to [unreleased regression] CiviCRM Admin Bar visible on 'Front End' of WP

@colemanw Thanks for the patch. I see that Joomla was referenced. I could not recreate the issue, but my Joomla experience is limited. Did we have reports of the menu appearing on the front end? I can say with the patch I don't se the admin bar on the Front End of Joomla or WP.

No, no reports, I just know that Joomla does have a concept of "front-end" and "back-end" like wordpress, so if Joomla was experiencing the same problem this patch should have fixed it there as well.

mentioned in commit b4d06dfe

mentioned in commit c931044d

@colemanw I did test on my joomla test site, and the menu did not appear on the front end on 5.12-rc. I then applied the patch and it is still not there.

closed