New Event using a template - clicking "Continue" doesn't save custom data

When creating a New Event from an Event Template, and entering custom data for the event, hitting "Continue" doesn't save the custom data. This happens for me on 5.10.4, on the CiviHosting demo which is running 5.10.0, and the CiviCRM Sandbox running 5.12.alpha1.

How to reproduce

1. Add a custom field to Event entities
2. Click Events > New event
3. Choose an Event Template
4. Enter the mandatory fields and the custom data
5. Click Continue
6. Reload the page to force CiviCRM to fetch the event from the database
7. Visit the Info and Settings tab
8. The custom data is unset

Hint

In my debugger I had a breakpoint in my implementation of hook_civicrm_pre() and this didn't trigger when Continue was pressed, but did when Save or Save and Done were pressed. If Continue bypasses pre() then perhaps it skips the Custom Data too?

added Concept approved regression triaged labels

@ken is this a recent regression @mattwire any thoughts on it

I just tried & failed to replicate this (on master but I don't think it has changed) - there must be some other factor involved - can you replicate on http://dmaster.demo.civicrm.org ?

removed regression label

Hmm - I see some changes that are in the 5.11 rc (due for release on Wed) that might relate - I retested against 5.11 & couldn't replicate it there either so I think we already merged a fix

@eileen I can replicate this bug on http://dmaster.demo.civicrm.org

I checked the JavaScript console and there are no errors or warnings.

My browser is Google Chrome 72.0.3626.109

So this is my attempt to replicate on master just now (which failed to replicate it )

@eileen thanks for sharing your screen grab. I think the issue has to do with Event Templates. On the sandbox, when I followed the same steps as you I didn't have the problem, but when I use the Event Template, I do.

I'll clarify the issue. Sorry for missing that detail - I just use templates automatically!

changed title from New Event - clicking "Continue" doesn't save custom data to New Event using a template - clicking "Continue" doesn't save custom data

changed the description

OK - try the fix here https://github.com/civicrm/civicrm-core/pull/13755 & comment on the PR as to your success

added regression label

mentioned in commit 4d19cca0

mentioned in commit f213a796

@eileen it works! You're a legend! I commented on the PR as requested

changed milestone to %5.11

closed

Unfortunately, I found that the problem still (or yet again) exists in 5.34.alpha1. I'm able to repoduce it on https://dmaster.demo.civicrm.org/:

I've used default values for custom field group and custom alphanumeric field.

Could we please reopen this issue or should I create a new one?

mentioned in issue #1160 (closed)

reopened

changed milestone to %5.34.0

closed

mentioned in commit 426cf44f

mentioned in commit b97d8059

@pminf just noting that I observed this problem in CiviCRM 5.35.1. But when I tested to confirm in CiviCRM 5.37.alpha1 it appeared to be working.

The bugfix was part of release 5.34.0. Glad to hear, that it's still working in 5.37.alpha1 ;)

mentioned in issue joomla#33 (moved)

mentioned in issue event#58 (moved)

reopened

I'm re-opening this bug report as the problem is again reproducible on CiviCRM 5.39.alpha1 and CiviCRM 5.37.2 - https://dmaster.demo.civicrm.org/

Custom values are not being saved on the Event, instead being saved on the Event Template, event#58 (moved)

And for this issue, Event custom values are not being saved when the Event is populated from a Template and the custom values are changed prior to saving.

Feel like we are going in circles much?

Agileware Ref: CIVICRM-1768

Yep - totally going in circles - I guess we haven't been insisting on unit tests enough

Honestly, I feel that the whole idea of "Event Templates" duplicates the "Copy Event" functionality. I would be supportive of removing "Event Templates" altogether as a feature. Is there anythiing that Event Templates provides that Copy Event does not?

Hmm - I guess it would have potentially less data - ie a very long time ago I used them because I wanted to repeat events which were about 50-50 specific & non- specific data

That's exactly what we use the copy event feature for and how we explain it in the CiviCRM training sessions too.

Re: event templates v event copy

For me it's the same reason we have Message Templates rather than just Reusing mailings.

If we copy an event we not only copy the "pattern" but also the "specific" elements for that event. And the template can include instructions for tailoring the event template, which would be lost in the copied event.

@ken I like the idea of including "instructions", but where do you put these instructions currently? In the actual event fields? As there's no capacity to provide instructions on any of the event tabs and I agree that this would be useful. Similar to the idea of CiviTutorial.

Yes ... in the Description field.

@justinfreeman That's exactly what the advancedevents extension does - get rid of the event_template as an event and create it's own table / entity for EventTemplates https://lab.civicrm.org/extensions/civicrm-advanced-events

@mattwire thanks for the pointer to your awesome extension, CiviCRM Advanced Events. Lots of great ideas bundled in there, well done

However, as you probably know the problem still exists: custom field values are not saved for an Event. I'll try and get funding to have this bug fixed.

Just replying to myself here. Our client has refused to fund fixing this bug.

So at this stage, Event Templates can be used. But if the Event Template has custom fields, then the custom field values are not saved. This is fairly easy to miss too, since the user is redirected to the 2nd tab, away from where the custom fields would be displayed. So they have to click back to the 1st tab, scroll down and possibly expand a section to be see the problem. Given the steps required, there's a fairly high chance that this will go unnoticed.

removed regression label

I'm just going to remove the regression label, that was added two years ago... Feel free to tag again.

Just a FYI. Eileen provided a PR with fix for event#58 (moved) - direct link https://github.com/civicrm/civicrm-core/pull/20675

Test.

changed milestone to %5.39.0

added regression label

Good news, have tested Eileen's PR 20675 and it fixes this issue as well as event#58 (moved)

This issue can be closed once PR 20675 has been merged. I've marked this as a "regression" same as the other issue and set the milestone to 5.39.0

closed

mentioned in issue #3382 (closed)