Misleading System Status message when CIVICRM_MAIL_LOG_AND_SEND is set

Overview

When one turns on the setting CIVICRM_MAIL_LOG_AND_SEND by following the documentation here: https://docs.civicrm.org/dev/en/latest/tools/debugging/#changing-file-based-settings which requires that you turn on CIVICRM_MAIL_LOG too

You get this system status warning:

This is misleading because mail IS going out AND being logged.

Reproduction steps

1. Turn on the setting CIVICRM_MAIL_LOG_AND_SEND by following the documentation here: https://docs.civicrm.org/dev/en/latest/tools/debugging/#changing-file-based-settings which requires that you turn on CIVICRM_MAIL_LOG too
2. Go to CiviCRM Admin Menu -> Administration Console -> System Status

Current behaviour

You will see an error telling you outbound email has been disabled:

But outbound email is going out

Expected behaviour

no warning

Comments

Relevant code is here: Code is here: https://github.com/civicrm/civicrm-core/blob/6.1/CRM/Utils/Check/Component/Env.php#L151

I will open a PR

changed title from Misleading error when CIVICRM_MAIL_LOG_AND_SEND is set to Misleading System Status message when CIVICRM_MAIL_LOG_AND_SEND is set

A pull request related to this issue has been opened with the title: #5824 Misleading System Status message when CIVICRM_MAIL_LOG_AND_SEND is set

added has-pull-request label

added comp:CiviMail triaged labels

mentioned in commit 4c46459b

mentioned in commit 1958cd0f