Non translatable fields in profile schema

There are a few fields in profile that should be translatable :

• Public Title
• Description (not a public data but some orgs have staff with different preferred language)
• Redirect URL
• Cancel redirect URL
• Cancel Button Text
• Submit Button Text

I have checked in the database and it seems that those field are translatable already, so for those it's just an UI problem :

• Public Title
• Cancel Button Text
• Submit Button Text

A fix for public title is here https://github.com/civicrm/civicrm-core/pull/13110/files

mentioned in commit 36c58960

added needs:concept approval triaged type:proposal labels

We have merged the UI fix for the above other 2 issues https://github.com/civicrm/civicrm-core/pull/13185. I'm not sure what the state of the other fields that being description and the 2 url fields

mentioned in commit 3791b491

mentioned in commit 5e59ce48

@samuelsov Can you review the status of this issue?

A quick status of this issue :

• public title mostly works but not in "On behalf" and maybe other specific use of profile (I'm going to provide a PR for this)
• cancel button text / submit button text are good
• description is not translatable but it's only for admins who create/edit profiles. I think we can drop this until it is displayed somewhere else.
• redirect url / cancel redirect url are not translatable but I've only seen one usecase of this so far. I don't think it is worth the trouble.

PR https://github.com/civicrm/civicrm-core/pull/19144

Also, in Confirm and Thank You contribution pages, the public title is not used.

mentioned in commit 5903c058

mentioned in commit 913b1e8c

mentioned in commit fc2e1993

mentioned in commit 6b04b7ea

mentioned in commit 0278c62a

Good enough for me. Let's close this.

closed