Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 983
    • Issues 983
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • Core
  • Issues
  • #498

Closed
Open
Opened Nov 01, 2018 by JKingsnorth@JKingsnorth

Undefined index in mailing report for mailing_modified_date; and room for refactoring

Notice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report() (line 1821 of /home/developer/buildkit/build/civicrmdev/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php).

Appears on pages like: /civicrm/mailing/report?mid=7&reset=1

This is because the DAO key for the field is 'mailing_modified_date' - but the name is 'modified_date'.

And the way the field values are assigned to the object does not account for this difference.

This is a very minor issue as the modified date doesn't actually get used in the report!

We should probably refactor the query/code to only load the fields we're actually interested in; and get rid of the raw SQL in the file at the same time: https://github.com/civicrm/civicrm-core/blob/f87c35c7308fc6876e1a4fea8ac3ea908d3d9453/CRM/Mailing/BAO/Mailing.php#L1807

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
5.9
Milestone
5.9
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#498