(regression) Extra receipt is sent when marking a contribution complete.
Overview
Starting in 5.69, changing a Pending contribution to Completed sends a receipt even if you choose not to.
Reproduction steps
- Create a new pending contribution on the backend.
- Click Edit.
- Change the contribution to complete.
Current behaviour
If you don't select "Send Receipt", a receipt is sent. If you do select "Send Receipt", 2 receipts are sent.
Expected behaviour
current situation minus 1.
Comments
The conversion from transitionComponents()
to Payment.create
is what occasioned this.