[php8] CRM_Core_Form_Tag::_entityTagValues seems to be in the wrong place
This class doesn't ever seem to get instantiated as its own form, and the property is always accessed from "outside" as $form->_entityTagValues
. There are two actual forms that declare the property - those declarations were added a year ago. The property has existed forever.
I'm thinking maybe it should live on CRM_Core_Form instead, or at least remove it from CRM_Core_Form_Tag and add it to the classes that call CRM_Core_Form_Tag functions. A larger refactor might instead make those classes contain an instance of CRM_Core_Form_Tag and then it could be protected inside there.
Also _tagsetInfo