ACL revamp causes crashes on many SearchKit queries in 5.67
Overview
This is a separate 5.67 regression from the ACL revamp than I reported Friday. This causes many SearchKit searches with an IN
operator to fail.
I've isolated the regression to commit 77b6e5ac3377cd1bfb1ebbc18bc9925caf06ad38
, which is part of PR #27472. I'm 99% certain it's this chunk of code.
Reproduction steps
Import and run this SearchKit query:
[
[
"SavedSearch",
"save",
{
"records": [
{
"name": "Individual_Donations_Membership_Corporate_Sponsorships_Totals",
"label": "Individual Donations, Membership, Corporate Sponsorships Totals",
"api_entity": "Contribution",
"api_params": {
"version": 4,
"select": [
"COUNT(id) AS COUNT_id",
"GROUP_CONCAT(DISTINCT Contribution_FinancialType_financial_type_id_01.name) AS GROUP_CONCAT_Contribution_FinancialType_financial_type_id_01_name",
"SUM(net_amount) AS SUM_net_amount"
],
"orderBy": [],
"where": [],
"groupBy": [
"financial_type_id"
],
"join": [
[
"FinancialType AS Contribution_FinancialType_financial_type_id_01",
"INNER",
[
"financial_type_id",
"=",
"Contribution_FinancialType_financial_type_id_01.id"
],
[
"Contribution_FinancialType_financial_type_id_01.id",
"IN",
[
"3"
]
]
]
],
"having": []
}
}
],
"match": [
"name"
]
}
]
]
Current behaviour
Crash.
Expected behaviour
No crash.