Misc form issues
Found a handful of form-related issues that are pretty quick to fix, just wanted to have the green light on them before opening the PR. All screenshots are taken from https://dmaster.demo.civicrm.org (v5.8.alpha1
)
Wrong layout in "Tags and Groups" accordion of "New Individual" form
The "Tag(s)" label+select group is missing a <br>
Missing class on text fields in "Dedupe exceptions"
The input fields are missing the standard `crm-form-text class
<select>
s in "Submit Credit Card Contribution" modal
Wrong class on The elements have the wrong class: crm-form-date
Applying the correct class, crm-form-select
doesn't change much, but allows Shoreditch to style the selects correctly
Textareas instead of text input in "Word Replacements" form
This one I'm not really sure is really a markup error, but it looks to me that instead of <textarea>
elements, the form would benefit by using input[type="text"]
fields instead (see how the checkboxes get a vertical alignment, for example)