Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 935
    • Issues 935
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #442

Closed
Open
Opened Oct 15, 2018 by AkA84@AkA84

Misc form issues

Found a handful of form-related issues that are pretty quick to fix, just wanted to have the green light on them before opening the PR. All screenshots are taken from https://dmaster.demo.civicrm.org (v5.8.alpha1)

Wrong layout in "Tags and Groups" accordion of "New Individual" form

The "Tag(s)" label+select group is missing a <br>

Before tags-before

After tags-after

Missing class on text fields in "Dedupe exceptions"

The input fields are missing the standard `crm-form-text class

Before dedupe-before

After dedupe-after

Wrong class on <select>s in "Submit Credit Card Contribution" modal

The elements have the wrong class: crm-form-date contribute-select-before

Applying the correct class, crm-form-select doesn't change much, but allows Shoreditch to style the selects correctly contribute-select-after

Textareas instead of text input in "Word Replacements" form

This one I'm not really sure is really a markup error, but it looks to me that instead of <textarea> elements, the form would benefit by using input[type="text"] fields instead (see how the checkboxes get a vertical alignment, for example)

Before replacement-before

After replacement-after

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
5.9
Milestone
5.9
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#442