Translation for site default language not loaded
When configuring message templates the translation system allows for draft and approved statuses. However, these apply to the the translations, not the message templates.
In order to use the approval flow it is necessary to create a translation for the site default language - at which point you would expect it to be used.
However, this line https://github.com/civicrm/civicrm-core/pull/26232/files#diff-466bc3af8c09d1d88e212c1465c6586e2d7187d27397e75f02e67436b1d4be13L181 currently causes the message template, not the tranlation to be called when the site default language is whistled up.
It's pretty clear that if you configure an English (United States) template you want it to be used but it gets more confusing for the expected behaviour for other languages - which should they fall back to. From a code / UI point of view this is not obvious but from a site usage point of view it is - ie
- the whole reason for creating the translation for the site default language is to have the approval work flow - you don't want it to by bypassed for other languages that fall back to it and ...
- you don't really want to have to be maintaining 2 templates for no added value.
The underlying issue is the lack of the statuses on the message templates and for any larger effort on this it would make sense to add it there & make the template obsolete.
It would perhaps also be possible to add a hook so that the message template is updated whenever the site default template with status=approved is updated. I worry a bit this could get confusing because there is an idea it could be turned back into a draft & then it would fall back on the message template again - but that would already have been updated.
It would also be possible to add more documentation / perhaps more UI notifications - although with little evidence other sites are using this and even if they have, have added translations for the default language I'm inclined to go with 'if someone translates the default language they did it so that it would be the one used' and make that work