Regression? Basic Fiscal relative date filters gone missing

Not sure when this happened but seems like a regression. Two of the built-in relative date filters for Fiscal year are gone missing from the UI. They are still present in the option group and seem to be present in CRM/Utils/Date.php For us this breaks quite a few smart groups and reports.

"This Fiscal year" and Previous "Fiscal Year" are gone now. Doublechecked in the sandbox.

changed the description

"This Fiscal Year" and "Previous Fiscal Year" are gone from the UI. The only one that is working is "Next Fiscal year", and that is the only one where $relativeTermSuffix is not involved.

I think this broke after the PR on fiscal year in May: https://github.com/civicrm/civicrm-core/pull/12137

added needs:concept approval sig:bug triaged labels

added prioritised label

@magnolia61 this seems to be something that is not new & which is deliberate in the code - see this chunk of code

    //if fiscal year start on 1 jan then remove fiscal year task
    //form list
    if ($config->fiscalYearStart['d'] == 1 & $config->fiscalYearStart['M'] == 1) {
      unset($selector['this.fiscal_year']);
      unset($selector['previous.fiscal_year']);
    }

If I change the fiscal year on administer/localization/date formats then the options appear again

removed prioritised label

OK, I understand what was going on with us NOW. One of the orgs I work with changed back to January 1st for the fiscal year.

I must say the code you mention is quite undocumented and violent as all smartgroups and reports broke on it.

I would opt to remove that piece of code. What's wrong with the fiscal year showing up if you can prevent our scenario?

@magnolia61 yeah I am ok with removing it - if you can make a case either way then the way with less code complexity should win :-) I would merge that if you want to put up a PR to remove those lines

@JoeMurray FYI ^^

I agree it's a non-convenient convenience :( to remove the fiscal date filter when it was already there.

I'm okay with changing this as suggested.

It will make Fiscal Year filters appear for many for first time as a result. The location of this setting is highly unintuitive as this is not a date format :(. We should at least replicate it on Admin > CiviContribute > CiviContribute Component Settings, if not move it there.

@eileen if you are agreeable with moving the setting, then JMA could volunteer to make that change. @monish.deb ^

@JoeMurray I'm OK with moving the setting - @monish.deb will need to check he's familiar with the way @mattwire & I have been consolidating those 'preferences' forms with the 'settings' forms first. (it's not rocket science but it would be easy to miss without taking a moment to look)

@monish.deb could you whip this little one off in the next day or two? @magnolia61 this is just a usability improvement that is only being suggested now because some people will be looking for this for the firat time when they start seeing fiscal year filters.

I'm closing this out as it is a request that hasn't moved in 2 years and it hasn't been raised in that time. We are trying to focus now on the search kit so I think if there is a request against the search kit we could look at that

closed