description is wrong for permission to view notes that are marked for author only
Overview
I am wondering if the label in https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Permission.php#LL785C46-L785C46 is correct. It is about the permission for viewing all notes. It says: "even if they're marked admin only", but I would expect: "even if they're marked author only". according to https://github.com/civicrm/civicrm-core/blob/master/sql/civicrm_data/civicrm_option_group/note_privacy.sqldata.php#L17
see https://chat.civicrm.org/civicrm/pl/ye4bu5w87b81mennu3at5ifcrr
Reproduction steps
- Go to User Permissions in Drupal (/admin/people/permissions)
- See the permission "CiviCRM: view all notes"
Current behaviour
The description says: View notes (for visible contacts) even if they're marked admin only
Expected behaviour
The description should say: View notes (for visible contacts) even if they're marked author only
Environment information
- CiviCRM: 5.60.0
- PHP: 8.1_
- CMS: Drupal 9.8.5_
Comments
see the labels for the options for the notes: None or Author only. https://github.com/civicrm/civicrm-core/blob/master/sql/civicrm_data/civicrm_option_group/note_privacy.sqldata.php#L17
There is nothing about "admin only"