Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 926
    • Issues 926
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #429

Closed
Open
Opened Oct 10, 2018 by ken@ken

Dedupe ignores Phone-Work-Mobile field

CRM_Dedupe_Finder uses a dedupe rule to find contacts who match the supplied fields (eg, when registering participants). This failed in the case when one of the supplied fields was a Phone.

This occurs when you register for an event where ...

  • The dedupe rule includes a Phone to get a match

  • The fields on the register page include a Phone that is not Primary (eg Work Mobile)

  • The registration data should match an existing contact if the phone number is used in the dedupe rule

However, a new contact is created.

What is required is to modify CRM_Dedupe_Finder::formatParams() to support dedupe rules that include non-Primary 'phone' fields. This was being blocked because profile fields named 'phone-N-N' were not being recognised as 'phone' fields. The regex that parses the field name recognised 'phone-Primary' and 'phone-Primary-2' and 'phone-2' as 'phone' fields. I extended the regex to recognise 'phone-6-2' as a 'phone' field.

Edited Oct 10, 2018 by ken
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#429