AFFORM: numerical fields are not checked when the form is submitted

See Wpmaster 5.60

Expected -> have an error message and do not allow the form submission

@Nadaillac thanks for reporting :-) Can you add a little more info on this issue if you expect anyone but yourself working on it? At the moment I would not know what the problem is?

added in-triage label

Sure ! This is a link to the chat https://chat.civicrm.org/civicrm/pl/784qxofxupgzxqse336p79pw8o

On WPmaster (5.60), i have created an activity type and 3 custom fields (2 numerical - number type-, field1 and field2 and 1 alpha). I have created a form with an activity tab (I set contacts source and with to an existing contact, set the activity type, no individual) and the fields "subject" + the 3 custom fields. Within Formbuilder, I set one custom numerical field -field1- to a number presentation and one custom numerical field -field2- to text presentation. If I input a letter in field1 and I submit -> I get an error message, if I input "1.5" I get also a message (has to be an integer, although the field1 has a numerical type number). If i input a letter in the numerical field2 (and fill in other fields correctly) and I submit, the activity is created, there is no error message, custom fields are left empty. There should be an error message and no activity creation.

I hope it is clearer. Tell me if you need sponsoring.

Thanks for the info @Nadaillac I am just doing the triage, I am not able to fix it. But you made me happy as a gatekeeper :-)

added comp:Afform triaged labels

removed in-triage label

Thanks a lot @ErikHommel :-)

assigned to @kurund

unassigned @kurund

The validation on the client and also server side is based on the type selected in the Form Builder UI. This is the reason why it allowed submission. However, it didn't save and ignored the invalid input.

I feel in additional to UI type validation, we might need to add server side field data type validation in order to prevent such behavior.

Unfortunately, I cannot help on the technical side. But I can provide the funding :-) !

A Nice to have would be to take also in account the setting in CiviCRM (language, currency and localization), on the decimal character. In French, the decimal character is the comma and in english it is the dot.

I think this PR fixes all of the above issues, including localized decimal markers: https://github.com/civicrm/civicrm-core/pull/26124

added has-pull-request label

There was an issue, regression when the patch was applied. Finally, the global extension afform was updated and it works now ! Thanks a lot !

@Nadaillac @colemanw

Should we close this issue?

Yes ! Thanks Kurund !

closed