Can the `CRM_Event_Badge` classes be deprecated and removed?
I recently came across these classes:
CRM_Event_Badge
CRM_Event_Badge_Logo
CRM_Event_Badge_Logo5395
CRM_Event_Badge_NameTent
CRM_Event_Badge_Simple
Stylistically they're not great, and I noticed they don't seem to be in use.
The last 4 of these classes extend CRM_Event_Badge
, and are referenced in the eventBadge
option group. However, I can't see any scenario where this eventBadge
option group is actually used.
The Event Name Badge Layouts
configuration screen gets stored in the civicrm_print_label
table, and CRM_Badge_BAO_Badge
is what actually get's used when you print a selection of badges for an event. CRM_Badge_BAO_Badge
does not use CRM_Event_Badge
(although they are very similar. I suspect one started as a copy of the other.)
I think it would make sense to:
- Check nobody is using the 5 classes listed above through a universe search.
- Noisily deprecated the 5 classes, specifying
CRM_Badge_BAO_Badge
should be used instead. - After a period of time remove the 5 classes.
- Tidy up (remove all trace of) the
event_badge
option group.
Of these, the last step is the one I'm most unsure of the process for. I guess it'd be removed through an upgrade step.