Improve colour contrast for SearchKit buttons when disabled
Overview
When a row in a SearchKit display is styled as 'disabled' it changes the text colour to grey. Unfortunately, this also affects the buttons. For the buttons grey doesn't have sufficient colour contrast to the button colour. See screenshot below.
I think it would be better to keep the text colour white for buttons and instead change the button colour to a more muted shade.
Reproduction steps
- Create a SearchKit display with buttons
- Add a conditional row style of 'Disabled' - e.g. if a row is marked as disabled.
Current behaviour
The colour contrast is poor and it is difficult to read the text on the buttons.
Expected behaviour
There should be sufficient colour contrast that users should be able to read the text on the buttons and it meets accessibility best practice.
Environment information
CiviCRM 5.56.alpha1
Comments
To fix this properly we should consider all six button styles (e.g. default, warning, success etc.) and all nine row styles (e.g. disabled, strikethrough, italic etc.). These could occur in any combination and all of them should provide sufficient colour contrast.
For context see: https://github.com/civicrm/civicrm-core/pull/24722#discussion_r995974092