Replace all calls to deprecated method CRM_Core_PseudoConstant::activityType()
There are calls to CRM_Core_PseudoConstant::activityType()
(deprecated) in many places such as $activityTypes = CRM_Core_PseudoConstant::activityType(TRUE, FALSE, FALSE, 'name');
but the actual method accepts no parameters. And changes to that method predate the migration from SVN... so some guesswork needs to be done.
Update: oops I just noticed it has func_get_args()
so it is accepting parameters after all.
In some cases it seems that it can be replaced with CRM_Core_PseudoConstant::getKey('CRM_Activity_BAO_Activity', 'activity_type_id', 'ACTIVITYNAME')
but in other cases it actually does need a list of activity types. And in some cases needs to filter out disabled components, which is what the original method is doing.