Import Custom Data - Review of refactorings
(Off-shoot from https://github.com/civicrm/civicrm-core/pull/23719)
I did some r-run
, and (broadly) the "Import Custom Data" in master
appears to work with this update. The examples I used were posted at https://github.com/eileenmcnaughton/testdata/pull/2
For a baseline, I compared against 5.49. There were a few quirks and changes.
- (Pre-existing/Unchanged Quirk) The "Start Year" field is defined as "YY" field, but you have to submit a full date. This was true in 5.49 as well.
- (Pre-existing/Unchanged Quirk) "Required" custom-fields are not really required. (That's fair for single-value data attached to another entity - but I'm unsure about multi-value data, where it feels like a separate entity.)
- (Improved) The "Level" field has a more clever/forgiving behavior -- in 5.49, it only matched the option-values numerically (
edu-longdate-full-num.csv
). With this update, matches by number as well as name (edu-longdate-full-name.csv
). I don't know if that means that are misbehaved edge-cases, but it does generally feel more forgiving. - (Changed) For invalid "Level" values like this number or this name, the behavior changed. In 5.49, it completely rejected the record due to the bad value; in 23719, it accepted the record but skipped the value.
- (Regressed) In 5.49, the importer reported the bad "Level" value at the end. In 23719, it inaccurately indicates success.