Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 920
    • Issues 920
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #333

Closed
Open
Opened Aug 16, 2018 by totten@tottenOwner

testTargetAddressFields() in 5.5 fails half the time

The test CRM_Report_Form_ActivityTest::testTargetAddressFields() was added in 5.5. 5.5 is the current RC, and test is failing frequently -- about half the time. (Recent build history)

I think the problem traces to this line. Evidently, the ordering must be non-deterministic -- i.e. both India;United States and United States;India come up in practice.

I don't know if that variation is acceptable or not. If it is acceptable, then the simplest change would be to make the assertion a logical OR (e.g. assert that $rows[0]['civicrm_address_country_id'] is either India;United States or United States;India). If the variation is significant... then I guess that would require something else...?

@monish.deb, can you figure out a patch for 5.5?

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
5.5.0
Milestone
5.5.0
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#333