Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 933
    • Issues 933
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #332

Closed
Open
Opened Aug 15, 2018 by AlanDixon@AlanDixon

updateSubscriptionBillingInfo no longer includes the recurring id

Payment processor objects can implement the method updateSubscriptionBillingInfo to implement payment-processor specific code to update card-on-file type information with the payment processor service, for recurring payments.

That call's second parameter "processorParams" no longer includes the id of the recurring contribution, as of sometime between 4.7.27 and 5.3.1. Previously it was accessible as "crid", presumably being included implicitly from the url.

Note that this appear to only affect payment processor implementations that depend on this value - some don't (it seems that they might be using a payment processor specific field called "processor_id" in the recurring table which is send as subscriptionId to the update method).

I would propose that the recurring id be included in the parameters, but let's use the recur_id key, since that's how it is included in the _subscriptionDetails array.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#332