Greeting tokens are not replaced in bulk sms

In mass sms, the postal greeting and emial greeting tokens are not replaced.

Deprecated token replacement method is used: https://lab.civicrm.org/dev/core/-/blob/5.48.1/CRM/Mailing/BAO/MailingJob.php#L596-623

@dmunio do you have the flexmailer extension enabled?

@eileen , Yes, I have active flexmailer.

@dmunio can you explain a bit more how others can reproduce this issue? And can you also state which CiviCRM and CMS Version (and SMS provider) you are using?

I don't know how @dmunio technical you are but it would be very helpful when you could find the cause and provide a pull request with a fix.

Anyway thanks for reporting!

@jaapjansma

• CiviCRM: 5.45.3 - Although I see that the code is the same in the latest version: 5.48.1
• Drupal 7.

Steps to reproduce the error:

1. Create an SMS that includes the tokens: {contact.email_greeting_display} {contact.postal_greeting_display}
2. Send bulk SMS (I did tests with Twilio and with Dummy).
3. Tokens are not replaced when sending SMS

I'm a programmer and I know CiviCRM code but I'm not sure the best way to solve this problem. I have only been able to identify that bulk SMS are sent using deprecated functions: https://lab.civicrm.org/dev/core/-/blob/5.48.1/CRM/Mailing/BAO/MailingJob.php#L596-623

Thanks! I am not sure either what the best way is to solve this. The token handling has been refactored quite recently.

@eileen, @mattwire or @totten do one of you know how to solve this issue?

added git:civicrm-core regression sig:bug labels

added triaged label

I have given this the regression label as it might be a regression bug. Feel free to remove the label if it is not a regression.

@dmunio this is a tricky one - I've had a first stab at how we could fix SMS to use flexmailer / token processor for it's token rendering - https://github.com/civicrm/civicrm-core/pull/23516

removed regression label

mentioned in commit 2a55af8e

mentioned in commit c3efce13

changed milestone to %5.51.0

closed