FormBuilder - setting a field as 'required' does not implement any validation check

Creating a submission form using Form Builder, it is possible to set any given field to be 'Required'.

I'm assuming that by doing this the form could not then be submitted if the required field is empty. A validation error should be resented assisting the user to complete the required field/s.

In practice the form can be submitted with no alert or apparent validation check taking place.

Using CiviCRM 5.47.2 with Wordpress.

added comp:FormBuilder sig:bug triaged labels

@Upperholme thanks for reporting the issue. Are you able to provide a pull request with a fix?

Wish I could, as this is holding me up. But it's some way out of my skillset - currently trying to understand how this FormBuilder system works.

Ah yes I can understand, I am not familiar with the form builder system either.

@jaapjansma Do you know when this issue could be fixed ?

@Nadaillac as you probably aware CiviCRM is open source which means it is maintained by a community of volunteers. So that also means that there is no supplier at which you can ask when this could be fixed. This means that if you encounter something which hinders, you can either solve it yourself, you can ask a CiviCRM partner to solve this for you (you probably have to paid them) or you can leave the issue and waits till someone fixes this.

You probably also have read that I am not familiar with the issue here at hand so I feel a bit annoyed by your question.

To be fair, I didn't take the query from @Nadaillac as an implication that you should be fixing this issue @jaapjansma - rather as a general enquiry, which is a fair question if someone isn't particularly familiar with how Civi works. From what I understand @colemanw is leading the work on the Form Builder, has said issues will broadly be addressed in order of priority and as funds are available. From my perspective it would be great to have this resolved, but right now it's not a massive priority for me right now, and I don't have available funds to support this work. So I'll be patient and look forward to seeing a fix at some point in the future, because having a working required field is pretty basic stuff for a useful form builder in my view. So if you are able to commit some funds towards a fix @Nadaillac - let @colemanw know and he'll likely be happy to prioritise this issue.

Thanks @Upperholme

Thanks @Upperholme @jaapjansma for your replies/ comments. And yes it was a simple question to know where we stand on that issue. @colemanw Yes, I can fund this fix :-).

Fantastic @Nadaillac that would be a great help. I'll assign this issue to myself. Are you able to fund around 4 hours of work for this?

Yes !! :-)

assigned to @colemanw

This is a 2-part issue, as validation need to happen on both the client-side and the server-side.

This fixes part 1 (needs review): https://github.com/civicrm/civicrm-core/pull/23604

Great ! I check when I am able to load the fix and test it. Thanks !

mentioned in issue #3728 (closed)

mentioned in issue extensions/certifications#14

Part 2: https://github.com/civicrm/civicrm-core/pull/24110

assigned to @kurund and unassigned @colemanw

@colemanw looks to me like you resolve this now with both Part 1 & 2? Should we close this one?

Hi,

Thank you for raising an issue to help improve CiviCRM. As you may know, this issue has not had any activity for quite some time, so we have closed it.

We would like you to help us to determine if this issue should be re-opened:

• If this issue was reporting a bug, can you attempt to reproduce it on a latest version of CiviCRM?
• If this issue was proposing a new feature, can you verify if the feature proposal is still relevant? Did it get the concept-approved label? Have other people also shown interest? Could it be implemented as an extension?

If the answer to either question is yes, please feel free to comment or re-open the issue. Please also consider:

• Is it something that you could help implement, either by sending a patch or hiring someone who can?
• Would you be willing to fund the work, either through a CiviCRM partner, or the Core Team?

Thank you for your help and contributions to CiviCRM.

P.S. This is an automated message, see infra/gitlab issue 20. We understand that automatic responses are annoying, but given the number of open issues as the project evolves, we need a bit of help to triage and prioritise the most relevant issues.

closed